Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Log line numbers on schema validation errors #388

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pretasoc
Copy link
Contributor

This is a pr for #387. It reports the line number of schema validations exceptions to the log in addition to the message.

I still need to collect some test cases and maybe tweak the formatting.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 11.53% and project coverage change: -0.69 ⚠️

Comparison is base (e4da0ad) 94.21% compared to head (cadf28c) 93.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   94.21%   93.52%   -0.69%     
==========================================
  Files          21       21              
  Lines        2973     2998      +25     
  Branches      466      470       +4     
==========================================
+ Hits         2801     2804       +3     
- Misses        115      136      +21     
- Partials       57       58       +1     
Impacted Files Coverage Δ
XmlSchemaClassGenerator/Generator.cs 76.92% <11.53%> (-11.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mganss
Copy link
Owner

mganss commented Jul 3, 2023

Thanks for creating the PR. I'm willing to merge. Could you just add a simple test to keep the coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants